assert: switch the diff library to go-diff #1546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitioshi
force-pushed
the
switch-diff-library-to-go-diff
branch
from
31ad2a7
to
bc848ba
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the diff library used in the assert package to go-diff.
Changes
the library used for diffing was replaced to go-diff/diffmatchpatch which is actively maintained and enables us to access structured diffs.
Motivation
See the parent PR for more context
difflibis no longer maintained and cannot be extended to modify the diff structure. We end up outputting whatever the library spews without being able to modify it easily. Having the access to the diff structure gives us a more fine-grained control over what we show to users.The initial motivation for this PR was to add colorized diffs to
assert.Equal. Accessing the diff structure would make this task trivialRelated issues
Split from #1480 as per @dolmen's suggestion