mock: simplify implementation of FunctionalOptions #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
added
pkg-mock
|
@snirye Could you review this change as you are a |
|
@nbaztec Could you review this change as you wrote the initial implementation? |
brackendawson
previously approved these changes
Apr 1, 2024
andrewwillette
approved these changes
Apr 1, 2024
Remove unnecessary use of reflect in the implementation of mock.FunctionalOptions().
dolmen
force-pushed
the
mock-simplify-FunctionalOptions-impl
branch
from
2a14d5a
to
d4a63f5
Compare
andrewwillette
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unnecessary use of reflect in the implementation of mock.FunctionalOptions().
Changes
FunctionalOptionsArgumentto be a slice of arguments to match the variadic argument ofFunctionalOptions.reflect.Motivation