-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🚫 DO NOT MERGE] [Connect] Prepare to publish StripeConnect module #4035
base: master
Are you sure you want to change the base?
[🚫 DO NOT MERGE] [Connect] Prepare to publish StripeConnect module #4035
Conversation
5fca70e
to
ca120b7
Compare
f759d22
to
289c7a6
Compare
5bbf80d
to
80135ce
Compare
1802618
to
cf3cbc1
Compare
80135ce
to
dc140d2
Compare
7ee34cb
to
00d6102
Compare
8a68f14
to
60a910a
Compare
baf7731
to
c04f948
Compare
97bb385
to
df4771b
Compare
6f39d37
to
19b7736
Compare
df4771b
to
60a80a3
Compare
|
Name | Version | Download | Change | Install | Change | Approval |
---|---|---|---|---|---|---|
StripeSize com.stripe.StripeSize |
1.0 (1) | 2.4 MB | ⬇️ 3.6 kB (-0.15%) | 7.8 MB | ⬇️ 11.1 kB (-0.14%) | N/A |
StripeApplePaySize com.stripe.StripeApplePaySize |
1.0 (1) | 433.2 kB | ⬇️ 1.4 kB (-0.32%) | 1.5 MB | ⬇️ 3.1 kB (-0.21%) | N/A |
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize |
1.0 (1) | 1.3 MB | ⬇️ 3.1 kB (-0.24%) | 4.3 MB | ⬇️ 5.9 kB (-0.14%) | N/A |
StripePaymentsSize com.stripe.StripePaymentsSize |
1.0 (1) | 1.1 MB | ⬇️ 3.4 kB (-0.29%) | 4.1 MB | ⬇️ 5.1 kB (-0.13%) | N/A |
StripePaymentsUISize com.stripe.StripePaymentsUISize |
1.0 (1) | 1.9 MB | ⬇️ 3.1 kB (-0.17%) | 6.3 MB | ⬇️ 6.9 kB (-0.11%) | N/A |
StripePaymentSheetSize com.stripe.StripePaymentSheetSize |
1.0 (1) | 3.4 MB | ⬇️ 8.8 kB (-0.26%) | 10.2 MB | ⬇️ 24.9 kB (-0.24%) | N/A |
StripeSize 1.0 (1)
com.stripe.StripeSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 11.1 kB (-0.14%)
Total download size change: ⬇️ 3.6 kB (-0.15%)
Largest size changes
Item | Install Size Change |
---|---|
StripePayments.STPBankAccountCollector.collectBankAccountForSetup... | ⬇️ -1.5 kB |
StripeUICore.TextFieldElement.BlikCodeConfiguration.value witness | ⬇️ -1.1 kB |
DYLD.Exports | ⬇️ -928 B |
StripePayments.STPBankAccountCollector.collectBankAccountForPayme... | ⬇️ -844 B |
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness | ⬇️ -740 B |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 3.1 kB (-0.21%)
Total download size change: ⬇️ 1.4 kB (-0.32%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness | ⬇️ -740 B |
DYLD.Exports | ⬇️ -712 B |
🗑 StripeCore.InstantDebitsLinkedBank.value witness | ⬇️ -552 B |
Other | ⬇️ -1.1 kB |
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 5.9 kB (-0.14%)
Total download size change: ⬇️ 3.1 kB (-0.24%)
Largest size changes
Item | Install Size Change |
---|---|
StripeFinancialConnections.FinancialConnectionsWebFlowViewControl... | ⬇️ -1.4 kB |
🗑 StripeFinancialConnections.Completed | ⬇️ -1.4 kB |
🗑 StripeFinancialConnections.HostControllerResult.HostControllerRes... | ⬇️ -1.3 kB |
StripeUICore.TextFieldElement.BlikCodeConfiguration.value witness | ⬇️ -1.1 kB |
StripeFinancialConnections.FinancialConnectionsWebFlowViewControl... | ⬆️ 964 B |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 5.1 kB (-0.13%)
Total download size change: ⬇️ 3.4 kB (-0.29%)
Largest size changes
Item | Install Size Change |
---|---|
StripePayments.STPBankAccountCollector.collectBankAccountForSetup... | ⬇️ -1.5 kB |
StripePayments.STPBankAccountCollector.collectBankAccountForPayme... | ⬇️ -844 B |
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness | ⬇️ -740 B |
📝 StripePayments.StubbedFinancialConnectionsLinkedBank.value witnes... | ⬆️ 740 B |
DYLD.Exports | ⬇️ -720 B |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 6.9 kB (-0.11%)
Total download size change: ⬇️ 3.1 kB (-0.17%)
Largest size changes
Item | Install Size Change |
---|---|
StripePayments.STPBankAccountCollector.collectBankAccountForSetup... | ⬇️ -1.5 kB |
StripeUICore.TextFieldElement.BlikCodeConfiguration.value witness | ⬇️ -1.1 kB |
DYLD.Exports | ⬇️ -960 B |
StripePayments.STPBankAccountCollector.collectBankAccountForPayme... | ⬇️ -844 B |
🗑 StripeCore.FinancialConnectionsLinkedBank.value witness | ⬇️ -740 B |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 24.9 kB (-0.24%)
Total download size change: ⬇️ 8.8 kB (-0.26%)
Largest size changes
Item | Install Size Change |
---|---|
📝 StripePaymentSheet.EmbeddedPaymentElement.Configuration.makePayme... | ⬆️ 5.0 kB |
📝 StripePaymentSheet.USBankAccountPaymentMethodElement.init(configu... | ⬆️ 4.0 kB |
🗑 StripePaymentSheet.PaymentSheetVerticalViewController.makeWalletH... | ⬇️ -3.8 kB |
🗑 StripePaymentSheet.PaymentElementConfiguration | ⬇️ -3.7 kB |
StripePaymentSheet.PaymentSheetVerticalViewController.init(config... | ⬇️ -3.2 kB |
🛸 Powered by Emerge Tools
🚨 New dead code detected in this PR: ConnectWebView.swift: warning: Function 'showErrorAlert(for:)' is unused
ConnectWebView.swift: warning: Function 'download(decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish()' is unused
ConnectWebView.swift: warning: Function 'download(_:decideDestinationUsing:suggestedFilename:)' is unused
ConnectWebView.swift: warning: Function 'download(_:didFailWithError:resumeData:)' is unused
ConnectWebView.swift: warning: Function 'downloadDidFinish(_:)' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
0c10880
to
bb8a81d
Compare
Standing up WIP branch with published package so we can test building against this in the Dashboard app. This will not be merged until we're ready to publish the SDK.
TODO
Summary
Added
StripeConnect
to package managers and installation tests in preparation for release.Motivation
https://jira.corp.stripe.com/browse/MXMOBILE-2496
Testing
Changelog