Link v3: Fix Billing Address Collection and a few other TODOs #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
force-pushed
the
relink/fix-todos
branch
from
ca23e86
to
b4a9ce7
Compare
|
🚨 New dead code detected in this PR: PaymentDetails.swift:28 warning: Initializer 'init(stripeID:details:billingAddress:billingEmailAddress:isDefault:)' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
wooj-stripe
reviewed
Nov 5, 2024
StripePaymentSheet/StripePaymentSheet/Source/Helpers/PaymentSheetLinkAccount.swift
Show resolved
Hide resolved
davidme-stripe
force-pushed
the
relink/fix-todos
branch
from
9acbf6c
to
c097920
Compare
wooj-stripe
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix billing address editing and submission, adding helpers to convert to/from the Link billing address structures. Address a few other TODOs in the Link code.
Motivation
Link v3 should support addresses.
Testing
Added tests for the address helpers.
Changelog
No user-facing changes.