Link v3: Add support for 2FA Modal and FlowController #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
changed the title
davidme-stripe
changed the title
wooj-stripe
reviewed
Nov 8, 2024
Comment on lines
42
to
49
| if configuration.forceEnableNativeLink && | ||
| self.supportsLink && | ||
| linkAccount.sessionState == .requiresVerification && | ||
| !linkAccount.hasStartedSMSVerification && | ||
| self.linkSettings?.suppress2FAModal != true { | ||
| return true | ||
| } | ||
| return false |
There was a problem hiding this comment.
can remove if and just return
return configuration.forceEnableNativeLink && ...
| let keyWindow = UIApplication.shared.windows.first(where: { $0.isKeyWindow }), | ||
| let presentedViewController = keyWindow.findTopMostPresentedViewController() | ||
| else { | ||
| assertionFailure("No key window with view controller found") |
| verificationController.present(from: self.bottomSheetViewController) { result in | ||
| switch result { | ||
| case .completed: | ||
| self.presentPayWithNativeLinkController(from: self.bottomSheetViewController, intent: loadResult.intent, elementsSession: loadResult.elementsSession, shouldOfferApplePay: true, shouldFinishOnClose: false) { |
There was a problem hiding this comment.
i would have expected shouldOfferApplePay to come from our configuration?
There was a problem hiding this comment.
Ah yes, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Enabling FlowController in Link v3.
Testing
PaymentSheet Example, will add end-to-end tests
Changelog
None yet