-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage payment method screen for default spm #4240
Conversation
🚨 New dead code detected in this PR: UpdatePaymentMethodViewController.swift:300 warning: Parameter 'sheetNavigationBar' is unused
STPCardBrand+PaymentsUI.swift:43 warning: Parameter 'maxWidth' is unused
AddressSpec+ElementFactory.swift:21 warning: Parameter 'setDisabledBackgroundColor' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
…stripe/stripe-ios into joyceqin-defaultspm-managepaymentmethod
…stripe/stripe-ios into joyceqin-defaultspm-managepaymentmethod
Card details cannot be changed., Manage card If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link. |
Summary
New screen for managing payment methods. Currently only supports cards. Remove only screen, cbc update or remove card screen.
Need to toggle "newUpdatePaymentMethodFlow" in the test playground or else it will show the current UpdateCardViewController.
I don't like the way I did the disabled background color code, but I wasn't sure how else to do it, so feedback on how to make that better would be appreciated.
Bug I found: If you edit the card brand and save and then delete a different card, the original card's brand reverts. This occurs with the original UpdateCardViewController as well. Only for horizontal.
Motivation
Sync default pms project
MOBILESDK-2661
MOBILESDK-2662
MOBILESDK-2663
MOBILESDK-2664
Testing
horizontalFlow.mp4
verticalFlow.mp4
Changelog