Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage payment method screen for default spm #4240

Closed
wants to merge 20 commits into from

Conversation

joyceqin-stripe
Copy link
Collaborator

@joyceqin-stripe joyceqin-stripe commented Nov 8, 2024

Summary

New screen for managing payment methods. Currently only supports cards. Remove only screen, cbc update or remove card screen.

Need to toggle "newUpdatePaymentMethodFlow" in the test playground or else it will show the current UpdateCardViewController.

I don't like the way I did the disabled background color code, but I wasn't sure how else to do it, so feedback on how to make that better would be appreciated.

Bug I found: If you edit the card brand and save and then delete a different card, the original card's brand reverts. This occurs with the original UpdateCardViewController as well. Only for horizontal.

Motivation

Sync default pms project
MOBILESDK-2661
MOBILESDK-2662
MOBILESDK-2663
MOBILESDK-2664

Testing

horizontalFlow.mp4
verticalFlow.mp4

Changelog

Copy link

github-actions bot commented Nov 8, 2024

🚨 New dead code detected in this PR:

UpdatePaymentMethodViewController.swift:300 warning: Parameter 'sheetNavigationBar' is unused
STPCardBrand+PaymentsUI.swift:43 warning: Parameter 'maxWidth' is unused
AddressSpec+ElementFactory.swift:21 warning: Parameter 'setDisabledBackgroundColor' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

Copy link

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Card details cannot be changed., Manage card

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

@joyceqin-stripe joyceqin-stripe marked this pull request as ready for review November 12, 2024 15:02
@joyceqin-stripe joyceqin-stripe requested review from a team as code owners November 12, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant