Remove qs package and implement URLSearchParams serializer #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented an URLSearchParams serializer
QuentinLemCode
requested review from
prathmesh-stripe
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This pull request removes the qs package and replaces it with a custom implementation of URLSearchParams serializer.
The
stringifyRequestDatafunction now serializes an object or string into URL-encoded parameters, accommodating nested objects and arrays.The goal of this change is to remove the
qsdependency which was used for this single function.It will allow to reduce the size of the stripe-node library.
URLSearchParams is available in all evergreen browser, NodeJS since v10, Deno since v1, and Bun.
Source : https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams
https://bun.sh/docs/runtime/nodejs-apis#urlsearchparams
This PR would close #2117