Include a useful error message when a null byte is found in the URL path #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
approved these changes
Feb 5, 2025
xavdid-stripe
changed the title
xavdid-stripe
changed the title
xavdid-stripe
added a commit
that referenced
this pull request
Feb 7, 2025
* Update generated code (#1793) * Update generated code for v1399 * Update generated code for v1409 * Update generated code for v1412 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> * Bump version to 16.4.0 * Added pull request template (#1797) * Add justfile, remove coveralls, and fix AUTOLOAD in CI (#1801) * add justfile and tweak CI + readme * debug test * Debugging * further debugging * restore original composer json * add more logging * maybe fix ci * Fix typo * fix test naming and pass autoload directly to recipe as arugment * Remove unused logline and fix typo * restore composer * remove extra log line * update justfile * add comments * update ci * revert to gh action * ensure dependencies are installed for format and test recipes (#1802) * Added CONTRIBUTING.md file (#1806) * minor justfile fixes (#1807) * made v2 event class concrete, and changed convertToStripeObject to use it if we cannot find the identified event subclass (#1805) * Update generated code for v1461 * Update generated code (#1804) * Update generated code for v1441 * Update generated code for v1452 * Update generated code for v1455 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: helenye-stripe <[email protected]> * Bump version to 16.5.0 * Make `httpClient()` a public, static method (#1810) * Make `httpClient()` a public, static method * Make `streamingHttpClient()` a public, static method * Update generated code for v1467 * Raise a more descriptive error if null bytes are found in the path (#1811) * raise a more descriptive error if null bytes are found in the path * formatting * change error thrown for null byte issues (#1813) * Update generated code for v1472 --------- Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Jesse Rosalia <[email protected]> Co-authored-by: David Brownman <[email protected]> Co-authored-by: helenye-stripe <[email protected]> Co-authored-by: Helen Ye <[email protected]> Co-authored-by: Johan de Jager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There are reports of cryptic 400 errors when PHP users include null bytes in API urls. We're not sure why this happens with PHP more often than other languages, but it seems to be the case.
Because we can't customize the error on the server side, we raise a more proactive error in the SDK to help users self-debug their issues.
What?
$absUrlright before making a requestSee Also