Add timeout in discover reader in dev-app #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-lin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
| @@ -148,6 +150,10 @@ export default function HomeScreen() { | |||
| loadDiscSettings(); | |||
| }, []); | |||
|
|
|||
| const validTimeoutMethod = () => { | |||
There was a problem hiding this comment.
This is currently valid for just bluetooth and usb discovery. Just a heads up that Android will be adding timeout support for discovering internet readers in the 4.0.0 release. I'm not too sure about when iOS will add it but might be a good idea to leave in a TODO for when both platforms provide support.
There was a problem hiding this comment.
Thanks for the heads up.
To me It's okey to leave it as it is because we also need to pass the timeout info later on when internet discovering is ready and that also require code change and test via the dev-app.
usaimbhayat-stripe
approved these changes
Sep 19, 2024
nazli-stripe
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add timeout in discover reader in dev-app
Motivation
Add timeout in discover reader for testing purpose
https://jira.corp.stripe.com/browse/TERMINAL-40545
Testing
Documentation
Select one: