Updating the extension activation triggers to only include Stripe-rel… #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated actions. This is in response to #187.
vcheung-stripe
approved these changes
Apr 28, 2021
gracegoo-stripe
added a commit
that referenced
this pull request
Apr 30, 2021
…ripe-related actions. (#219)" This reverts commit 815b5e2. See this comment change for more details: 815b5e2#commitcomment-50155816
gracegoo-stripe
added a commit
that referenced
this pull request
Apr 30, 2021
…ripe-related actions. (#219)" (#221) This reverts commit 815b5e2. See this comment change for more details: 815b5e2#commitcomment-50155816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated actions.
cc @richardg-stripe
r? @vcheung-stripe
Summary
This change is in response to #187 and will only trigger the activation of the extension if the users opens up the extension panel or tries to run a stripe command.
This does prevent the pre-loading of the extension which could mean that users experience a slower response for their first Stripe command (but I haven't noticed this while testing). If we find that our activation is heavy enough to benefit from loading earlier, another alternative is to move all the prompt-producing checks out of the activation step. I think that would complicate things though so I'd rather give this a try first.
Testing
Moved my stripe installation to another folder the extension wouldn't be able to find.