Skip to content

Commit

Permalink
Problem: Invalid project.xml XML file.
Browse files Browse the repository at this point in the history 
Failure detected with 'xmlstarlet' and 'xpath':
```
prompt> xmlstarlet val -w ./project.xml
./project.xml - invalid
prompt> xpath ./project.xml '/project/text()'

duplicate attribute at line 8, column 4, byte 242:
    email = "[email protected]"
    url = "https://github.com/zeromq/zyre"
    license = "MPL-2.0"
===^
    repository = "https://github.com/zeromq/zyre"
    unique_class_name = "0"
 at /usr/lib64/perl5/vendor_perl/XML/Parser.pm line 187.
prompt>
```

Confirmation:
```
<project
    name = "zyre"
    description = "an open-source framework for proximity-based P2P apps"
    script = "zproject.gsl"
    license = "MPL-2.0"                       <---
    email = "[email protected]"
    url = "https://github.com/zeromq/zyre"
    license = "MPL-2.0"                       <--- Duplicate entry.
    repository = "https://github.com/zeromq/zyre"
    unique_class_name = "0"
    >
```

Solution:
Remove the 2nd redundant entry.
Thankfully, both are identical.

Note zeromq#1:
> Introduced with zeromq#538 merge and fixed twice with
> - 0790f17
> - e13e990
> :-)

Note zeromq#2:
> The same tools report also invalid XML for api/*.api files.
> Fixing both would change too much documentations...
  • Loading branch information
@stephan57160
stephan57160 committed Sep 6, 2022
1 parent 5c30222 commit 94001c5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion project.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
license = "MPL-2.0"
email = "[email protected]"
url = "https://github.com/zeromq/zyre"
license = "MPL-2.0"
repository = "https://github.com/zeromq/zyre"
unique_class_name = "0"
>
Expand Down

0 comments on commit 94001c5

Please sign in to comment.