Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2203 : Improve Spanwise Section Error Handling in Turbomachinery Simulations #2457

Closed
wants to merge 2 commits into from

Conversation

aryan0931
Copy link

@aryan0931 aryan0931 commented Mar 1, 2025

Proposed Changes

This PR aims to:

  • Modify ComputeNSpan in CPhysicalGeometry.cpp to throw a detailed error if fewer than 2 spanwise sections are detected, prompting users to verify hub-to-shroud edge definitions in their mesh.
  • Improve the error message for unequal inflow and outflow spanwise sections, clarifying it’s likely a mesh issue and recommending mesh regeneration.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@aryan0931 aryan0931 closed this Mar 3, 2025
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why you closed the PR?

@aryan0931
Copy link
Author

Sir I have raised another PR.

@aryan0931
Copy link
Author

May I ask why you closed the PR?

Please review my another pull request sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong spanwise sections calculation in Turbomachinery simulation
2 participants