Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Rails 6 final #675

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Bump to Rails 6 final #675

merged 3 commits into from
Aug 20, 2019

Conversation

sudara
Copy link
Owner

@sudara sudara commented Aug 18, 2019

This was the result of bundle update after removing version specificity on Rails and webpacker.

sass-rails and compass both jumped major versions and need due diligence.

@@ -466,7 +460,7 @@ GEM
climate_control (>= 0.0.3, < 1.0)
thor (0.20.3)
thread_safe (0.3.6)
thredded (0.16.12)
thredded (0.16.13)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.13 is the only release compatible with rails 6.0 final.

@sudara
Copy link
Owner Author

sudara commented Aug 18, 2019

Looks like we can't upgrade sass-rails until we remove dark theme and compass sass/sassc-rails#79

@sudara sudara merged commit f9b45c2 into master Aug 20, 2019
@sudara sudara deleted the rails6final branch August 20, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant