New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves Volume Bug #4372

Closed

falgun143 wants to merge 0 commits into sugarlabs:master from falgun143:master

Contributor

falgun143 commented Feb 9, 2025

@walterbender @pikurasa please review

Removed the code causing the bug and eliminated unused functions.
Replaced tempSynth with synth, as previously tempSynth = instruments[turtle]["electronic synth"] was hardcoded. Now we use the specific instrument name, where synth = instruments[turtle][instrumentName].

falgun143 marked this pull request as draft

February 9, 2025 18:23

Member

walterbender commented Feb 9, 2025

I am not sure what the "bug" is you refer to in your commit message.

falgun143 closed this

falgun143 force-pushed the master branch from 18395e5 to 93c40c8 Compare

February 10, 2025 10:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet