Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Change: Changed the styling of save dropdown list to icons #4401

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arjunjayan999
Copy link
Contributor

This PR includes changes to improve the save dropdown styling and update the save icons. I have added inline SVG directly into the HTML for now(It looks a little bloated and ugly in the HTML) from the artwork.js, couldn't find 4 icons (HTML, MXML, BlockArt-PNG, BlockArt-SVG), so got them from iconify and the tooltips for all icons.
Idea was suggested by @walterbender in a separate PR.
There is currently a bug i found where changing to advanced mode will make the save dropdown unusable until the page is refreshed and vice-versa for going from advanced to beginner. It was already there and should be sorted out in a separate PR, I think.
There was a minor bug in language dropdown not changing theme because of a previous PR, fixed it.

Styling and Dropdown Menu Enhancements:

  • css/activities.css: Added new styles for #saveddropdown.active and #saveddropdownbeg.active to enhance the appearance and layout of active dropdown menus.
  • css/themes.css: Introduced new styles for dropdown content in dark mode, including background color and hover effects for links. [1] [2]

HTML Structure Updates:

  • index.html: Updated the structure of dropdown menus for saving options, replacing li elements with a elements and adding SVG icons with tooltips for better user experience.

Demo

Screen.Recording.2025-02-13.184955.mp4

@arjunjayan999
Copy link
Contributor Author

@walterbender please review this

@falgun143
Copy link
Contributor

@arjunjayan999 looks good.

@Commanderk3
Copy link
Contributor

@arjunjayan999 Looks good but I like the original serial list style. I think a serial list style with the icons would be good. But you did a good job.

@omsuneri
Copy link
Member

@arjunjayan999 my vote is with the old version cause we have two things i.e artwork and block connection so this representation seems difficult to distuinguish between those for the child user
also i suggest you adding a small logo of the export type before the text in the list this can be better i guess
@pikurasa can you suggest something from children's perspective

@walterbender
Copy link
Member

I like the idea of it, but the icons need some work as per @omsuneri 's comment.

@arjunjayan999
Copy link
Contributor Author

arjunjayan999 commented Feb 13, 2025

@walterbender Any tips on where I can find icons? I tried finding them in well known libs, but didn't find any since these are a little niche file formats like mxml, ly, abc, etc.
I saw there might be a lack of visual clarity without the text but I thought better to start with how you described it before, will work on that after sorting out icons. Better to get them all from the same icon pack, that inconsistency in style is the problem right now I think

@walterbender
Copy link
Member

I think that you should ask for help on the Sugar channel. There are some great designers there, like Perrie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants