Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing dependency intltool #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srevinsaju
Copy link
Member

Dependency intltool was missing from Documentation

Dependency `intltool` was missing from Documentation
@Aniket21mathur
Copy link
Contributor

Aniket21mathur commented Dec 3, 2019

I don't think explicitly defining intltool as a dependency is a good idea. It gets installed once you build dependencies for sugar. Though I will like to know what others think.

What is the error that you got?

@aperezbios
Copy link
Contributor

I completely disagree. All build dependencies should be explicitly laid out. Nothing should be assumed, including in this case.

@srevinsaju
Copy link
Member Author

@Aniket21mathur
This is the error:
intltoolize: command not found

@quozl
Copy link
Contributor

quozl commented Dec 3, 2019

Thanks. I agree with both @Aniket21mathur and @aperezbios. Please complete the list of dependencies before making a commit. See my comment in #884.

@Aniket21mathur
Copy link
Contributor

This is the error:
intltoolize: command not found

Thanks, noted. Clearly indicates that the dependencies are not built before installing. Please build before installing. :-)

@srevinsaju
Copy link
Member Author

srevinsaju commented Feb 8, 2020

Seems like I have got the list of rudimentary dependencies required for running sugar on any platform:

Looking forward for comments and corrections, I will add on if more are found.
Please review @quozl @aperezbios

@quozl
Copy link
Contributor

quozl commented Feb 10, 2020

Thanks.

But that looks like an Arch list, and it is not correct for Debian or Fedora. If we're going to maintain them, the dependencies must be listed in a form that is not distribution specific. I said this earlier in #884.

They also have to form part of the commit, not as a pull request comment.

You can find the downstream dependencies on Fedora by looking at the .spec file, and on Ubuntu by looking at the debian/control file.

We used to maintain platform components as a set of dependencies of Sugar and assumed to be present dependencies for activities. That effort died.

@srevinsaju
Copy link
Member Author

@quozl
Copy link
Contributor

quozl commented Feb 14, 2020

No. Like our previous platform components page, using the formal project name for each dependency. After that we could add distribution-specific package names, but those names rarely match the formal project name. Also, the formal project names rarely change, but distributions often change the package name from release to release.

@AakashKota

This comment was marked as off-topic.

@chimosky

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants