Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 fixes #919

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

Saumya-Mishra9129
Copy link
Member

No description provided.

Copy link
Member

@srevinsaju srevinsaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@Saumya-Mishra9129
Copy link
Member Author

present = GObject.Property(type=bool, default=False, getter=is_present)

The above line or any such line shows a warning "Unexpected argument". I couldn't be able to get why it so.

@Saumya-Mishra9129 Saumya-Mishra9129 marked this pull request as ready for review May 24, 2020 20:41
Copy link
Contributor

@quozl quozl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

extensions/cpsection/aboutcomputer/model.py Outdated Show resolved Hide resolved
extensions/cpsection/backup/view.py Outdated Show resolved Hide resolved
src/jarabe/frame/activitiestray.py Outdated Show resolved Hide resolved
src/jarabe/frame/activitiestray.py Outdated Show resolved Hide resolved
src/jarabe/frame/activitiestray.py Outdated Show resolved Hide resolved
src/jarabe/model/filetransfer.py Show resolved Hide resolved
src/jarabe/model/neighborhood.py Outdated Show resolved Hide resolved
src/jarabe/model/network.py Outdated Show resolved Hide resolved
@Saumya-Mishra9129 Saumya-Mishra9129 force-pushed the pep8-fixes branch 4 times, most recently from 7963995 to d63da3d Compare May 26, 2020 07:13
@Saumya-Mishra9129
Copy link
Member Author

layout = property(None, _set_layout)

The way we have defined _set_layout is not correct way. Setter should not return any value.

@Saumya-Mishra9129
Copy link
Member Author

@quozl @pro-panda Please review.

@srevinsaju
Copy link
Member

@Saumya-Mishra9129 although, not a big issue, there is a typo on dbddda3 's commit message

extensions/cpsection/webaccount/web_service.py Outdated Show resolved Hide resolved
extensions/cpsection/webaccount/web_service.py Outdated Show resolved Hide resolved
tests/extensions/cpsection/webaccount/web_service.py Outdated Show resolved Hide resolved
tests/extensions/cpsection/webaccount/web_service.py Outdated Show resolved Hide resolved
@Saumya-Mishra9129
Copy link
Member Author

@quozl Can you please tell me why we used Webkit and Webkit2 support for Sugar.? I am a little confused about it.

@quozl
Copy link
Contributor

quozl commented May 28, 2020

@Saumya-Mishra9129, sure, you can see in the commit descriptions of the commits that changed the imports. Some systems on which Sugar is being used did not have WebKit2, so both versions are supported by Sugar.

@Saumya-Mishra9129
Copy link
Member Author

@Saumya-Mishra9129, sure, you can see in the commit descriptions of the commits that changed the imports. Some systems on which Sugar is being used did not have WebKit2, so both versions are supported by Sugar.

Thanks
I am done with changes here @quozl you can review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants