Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): ignore deprecated unused file #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Ignore deprecated unused file, increase coverage to 75%
  • Can be removed on next release.

@juancarlospaco juancarlospaco changed the title chore(tests): ignore deprecated unused file, increase coverage to 75% chore(tests): ignore deprecated unused file Feb 7, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13191782651

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+13.6%) to 73.892%

Totals Coverage Status
Change from base Build 13058571237: 13.6%
Covered Lines: 1367
Relevant Lines: 1850

💛 - Coveralls

@juancarlospaco juancarlospaco marked this pull request as ready for review February 7, 2025 02:16
@grdsdev
Copy link
Contributor

grdsdev commented Feb 7, 2025

@juancarlospaco but is this code deprecated? Are you sure?

@juancarlospaco
Copy link
Contributor Author

juancarlospaco commented Feb 7, 2025

No other code imports it, Supabase main lib does not import it,
leftover legacy file, waiting to be removed in a future big release,
it is there since it has been refactored to use httpx,
the relevant detail is that the rest of the code has nice coverage whatsoever. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants