fix(typescript): function only have union over args #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
commented
Mar 30, 2025
Comment on lines
+163
to
+183
| CREATE OR REPLACE FUNCTION public.get_user_audit_setof_single_row(user_row users) | ||
| RETURNS SETOF users_audit | ||
| LANGUAGE SQL STABLE | ||
| ROWS 1 | ||
| AS $$ | ||
| SELECT * FROM public.users_audit WHERE user_id = user_row.id; | ||
| $$; | ||
|
|
||
| CREATE OR REPLACE FUNCTION public.get_todos_setof_rows(user_row users) | ||
| RETURNS SETOF todos | ||
| LANGUAGE SQL STABLE | ||
| AS $$ | ||
| SELECT * FROM public.todos WHERE "user-id" = user_row.id; | ||
| $$; | ||
|
|
||
| CREATE OR REPLACE FUNCTION public.get_todos_setof_rows(todo_row todos) | ||
| RETURNS SETOF todos | ||
| LANGUAGE SQL STABLE | ||
| AS $$ | ||
| SELECT * FROM public.todos WHERE "user-id" = todo_row."user-id"; | ||
| $$; |
There was a problem hiding this comment.
note
Those will also be used to improve the introspection to provide automatic types inferences for embeded functions select joins in follow-up PR's.
Comment on lines
+281
to
+282
| Args: ${fns | ||
| .map(({ args }) => { |
There was a problem hiding this comment.
note
The loop is now at the Args level to unionize.
Comment on lines
+301
to
+318
| Returns: ${(() => { | ||
| // Case 1: `returns table`. | ||
| const tableArgs = fns[0].args.filter(({ mode }) => mode === 'table') | ||
| if (tableArgs.length > 0) { | ||
| const argsNameAndType = tableArgs.map(({ name, type_id }) => { | ||
| const type = types.find(({ id }) => id === type_id) | ||
| let tsType = 'unknown' | ||
| if (type) { | ||
| tsType = pgTypeToTsType(type.name, { types, schemas, tables, views }) | ||
| } | ||
| return { name, type: tsType } | ||
| }) | ||
|
|
||
| return `{ | ||
| ${argsNameAndType.map( | ||
| ({ name, type }) => `${JSON.stringify(name)}: ${type}` | ||
| )} | ||
| }` |
There was a problem hiding this comment.
note
Single Returns using the first element within the fns array as source of truth.
soedirgo
approved these changes
Mar 31, 2025
Pull Request Test Coverage Report for Build 14155356078Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Into the more correct:
This also will fix on the type inference side the return type for
rpcfunctions calls from an union of object, to a single object.