Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing DAGSet ID test #23

Merged
merged 2 commits into from
May 3, 2024
Merged

Fixing DAGSet ID test #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a079905
Fixing DAGSet ID test
pshriwise May 2, 2024
b6c123f
Correct del call and add comments on intended testing
pshriwise May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,18 +181,25 @@ def test_id_safety(request):
with pytest.raises(ValueError, match="already"):
v1.id = used_vol_id

# set volume 1 to a safe ID and ensure assignment was successful this
# assignment should free the original ID of 1 for use
safe_vol_id = 9876
v1.id = safe_vol_id
assert v1.id == safe_vol_id

v2 = Volume.create(model)
# create a second volume and ensure it gets the next available ID
v2 = dagmc.Volume.create(model)
assert v2.id == safe_vol_id + 1

# update the value of the first volume, freeing the ID
safe_vol_id = 101
v1.id = safe_vol_id
del v2
# delete the second volume, freeing its ID as well
v2.delete()

v3 = Volume.create(model)
# create a new volume and ensure that it is automatically assigned the
# lowest available ID
v3 = dagmc.Volume.create(model)
assert v3.id == safe_vol_id + 1

s1 = model.surfaces_by_id[1]
Expand Down
Loading