-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use peer dependencies rather than dev dependencies #11433
Conversation
🦋 Changeset detectedLatest commit: 39e4fe5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR makes use of
|
Yarn PnP is broken, and we do not support it. Use npm or pnpm instead. |
Yarn PnP with Yarn 4 works on SvelteKit 2.0.7, but not on SvelteKit 2.0.8. |
You can restore compatibility if you fallback to just EDIT: I don't use Svelte in my day-to-day so I don't know if this is feasible/common, but if there are wrapper packages around SvelteKit, looks like this change would break the setup of a developer linking to that wrapper. And, FWIW, you wouldn't need this change at all if you were using PnP -- it can correctly resolve peer dependencies across portals (Yarn's equivalent to |
## What's the problem this PR addresses? The SvelteKit E2E test has been failing ## How did you fix it? - `create-svelte` discontinued the `next` dist-tag, use `latest` instead - I don't know how it was but `yes` cannot defeat `create-svelte` interactivity now, so I just use its node API instead - Also added a TypeScript test The test should still be failing due to sveltejs/kit#11433 (comment), but at least it is an actual failure of the E2E test, not of our setup. :shrug: Closes #6345 ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. --------- Co-authored-by: Kristoffer K. <[email protected]>
Right now it's rather difficult to use Svelte 5 alongside a linked
@sveltejs/kit
, because Kit importsvite
and@sveltejs/vite-plugin-svelte
relative to itself, even though these are peer dependencies.This means that components will be compiled by Svelte 4 (as that's what the
@sveltejs/vite-plugin-svelte
inside the linked@sveltejs/kit
depends on), but then try to use the Svelte 5 runtime.This is already a nuisance but it will become much more of one as Svelte 5 gets closer to release and we're trying to make sure everything works in both versions.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.