Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better missing peer dep error #11598

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

per #11578 (comment), the current message isn't very helpful when you have a missing peer dependency


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 3ea632b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

I'd rather revert the change completely. It would reenable yarn pnp to some extent (not that this argument matters too much tbh), but also letting handle node resolution algorithm handle these cases feels better to me than relying on a runtime lookup. It may also result in breakage where previously a dependency was found somewhere else which it is no longer now, which strictly speaking is a breaking change.
Given that this was only introduced to make Svelte 5 linking a bit easier I'm in favor or reverting.

@Rich-Harris
Copy link
Member Author

Not sure I understand this hypothetical breakage scenario?

Discounting that, we're basically choosing between PnP support and our own sanity. I think you're underestimating just how painful it will be, on an ongoing basis, to develop against multiple versions of peer dependencies. I found it nightmarish. And I really don't care about PnP

@dummdidumm dummdidumm merged commit 60ad7d1 into main Jan 11, 2024
13 checks passed
@dummdidumm dummdidumm deleted the better-missing-peer-dep-error branch January 11, 2024 15:43
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants