Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take snippets into account when scoping css selectors #10208

Closed
wants to merge 1 commit into from

Conversation

dummdidumm
Copy link
Member

This is an attempt to fix #10143
The CSS scoping logic is enhanced to take render tags into account - if one is found as the child of an element, we assume that the selector might match at runtime when combining the element(s) above the render tag and the element(s) inside the snippet. This doesn't do any advanced static analysis checks, so there can be false positives. I also notices that it's not enough to just check the current element for render tags, we need to do that recursively. I'm not sure I'm going down the right path doing this though, so I'm going to leave this as a draft for now for others that have worked in this code area before to take a look first.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 96f432d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Jul 5, 2024

@dummdidumm Is this PR still a WIP?

@dummdidumm
Copy link
Member Author

Yeah still WIP, question still open - i'd leave it open and come back to it later

@Rich-Harris Rich-Harris added this to the 5.0 milestone Oct 5, 2024
@dummdidumm
Copy link
Member Author

Closing in favor of #13589

@dummdidumm dummdidumm closed this Oct 13, 2024
@dummdidumm dummdidumm deleted the snippet-css-scope branch October 13, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Nested styles for snippets - scope issue
3 participants