Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make each items reassignable #12257

Merged
merged 11 commits into from
Sep 20, 2024
Merged

fix: make each items reassignable #12257

merged 11 commits into from
Sep 20, 2024

Conversation

Rich-Harris
Copy link
Member

Closes #12254. I thought this would be a super simple fix, and it is, but in the process of adding a test I uncovered a separate bug: if a bound prop is updated during rendering, it isn't invalidated. See Svelte 4 vs Svelte 5. I don't have any immediate thoughts on how to fix that, so I'm just going to leave this here for now.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 3c32413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris changed the title Gh 12254 fix: make each items reassignable Jul 2, 2024
@Rich-Harris Rich-Harris merged commit 9e511b1 into main Sep 20, 2024
7 of 9 checks passed
@Rich-Harris Rich-Harris deleted the gh-12254 branch September 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad compilation of valid Svelte 4 components under Svelte 5
3 participants