Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access last safe value of prop on unmount (alternative) #15366

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Rich-Harris
Copy link
Member

Doesn't work with spreads yet

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: e19eb31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15366

@thes01
Copy link

thes01 commented Feb 24, 2025

Hi! Thanks for looking into this!

I've played a bit with the provided playground and I stumbled upon a curious case: https://svelte.dev/playground/4aff7feff74b4442a4d32f7de3b53e85?version=pr-15366

If you have a bindable prop and assign to it in onDestroy then although the prop change is propagated, the subsequent read is still the old value. This seems to be quite an edge case, but wanted to report that while the PR is being baked.

I guess it could make sense to disable mutating bindable props in the destroying state..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants