Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use moveBefore on supported browsers #15512

Closed
wants to merge 3 commits into from
Closed

chore: use moveBefore on supported browsers #15512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07f01eb
move_before
adiguba Mar 14, 2025
e37a936
prototype
adiguba Mar 14, 2025
555321f
changeset
adiguba Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-onions-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: use moveBefore on supported browsers
5 changes: 3 additions & 2 deletions packages/svelte/src/internal/client/dom/blocks/each.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ import {
clear_text_content,
create_text,
get_first_child,
get_next_sibling
get_next_sibling,
move_before
} from '../operations.js';
import {
block,
Expand Down Expand Up @@ -584,7 +585,7 @@ function move(item, next, anchor) {

while (node !== end) {
var next_node = /** @type {TemplateNode} */ (get_next_sibling(node));
dest.before(node);
move_before(dest, node);
node = next_node;
}
}
Expand Down
13 changes: 13 additions & 0 deletions packages/svelte/src/internal/client/dom/operations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export var is_firefox;
var first_child_getter;
/** @type {() => Node | null} */
var next_sibling_getter;
/** @type {(new_node: Node, reference_node: Node) => void} */
var move_before_func;

/**
* Initialize these lazily to avoid issues when using the runtime in a server context
Expand All @@ -39,6 +41,8 @@ export function init_operations() {
first_child_getter = get_descriptor(node_prototype, 'firstChild').get;
// @ts-ignore
next_sibling_getter = get_descriptor(node_prototype, 'nextSibling').get;
// @ts-ignore
move_before_func = element_prototype.moveBefore ?? element_prototype.insertBefore;

// the following assignments improve perf of lookups on DOM nodes
// @ts-expect-error
Expand Down Expand Up @@ -91,6 +95,15 @@ export function get_next_sibling(node) {
return next_sibling_getter.call(node);
}

/**
* @template {Node} N
* @param {N} node
* @param {N} new_node
*/
export function move_before(node, new_node) {
move_before_func.call(node.parentElement, new_node, node);
}

/**
* Don't mark this as side-effect-free, hydration needs to walk all nodes
* @template {Node} N
Expand Down