Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameter for running outro transitions on $destroy #9056

Open
wants to merge 4 commits into
base: svelte-4
Choose a base branch
from

Conversation

ehrencrona
Copy link
Contributor

@ehrencrona ehrencrona commented Jul 28, 2023

Make it possible to run outro transitions when manually calling $destroy on a component.

In Svelte 4, the workaround mentioned in #4056 no longer works because those APIs are not public / exported.

Fixes #4056

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

⚠️ No Changeset found

Latest commit: 85e83ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehrencrona ehrencrona changed the title fix: Flag for whether to run outro transitions on $destroy feat: Flag for whether to run outro transitions on $destroy Jul 28, 2023
@ehrencrona ehrencrona changed the title feat: Flag for whether to run outro transitions on $destroy fix: Flag for whether to run outro transitions on $destroy Jul 28, 2023
@benmccann benmccann changed the title fix: Flag for whether to run outro transitions on $destroy feat: parameter for running outro transitions on $destroy Jul 28, 2023
@Conduitry
Copy link
Member

If we want to do this, we should strongly consider having it be an options object (with only one option for now), rather than being a positional parameter that we may come to regret.

@ehrencrona
Copy link
Contributor Author

@benmccann @Conduitry good feedback, thanks! i've updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$destroy don't play outro transition
3 participants