-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parameter for running outro transitions on $destroy
#9056
base: svelte-4
Are you sure you want to change the base?
feat: parameter for running outro transitions on $destroy
#9056
Conversation
|
documentation/docs/04-compiler-and-api/02-client-side-component-api.md
Outdated
Show resolved
Hide resolved
$destroy
If we want to do this, we should strongly consider having it be an options object (with only one option for now), rather than being a positional parameter that we may come to regret. |
@benmccann @Conduitry good feedback, thanks! i've updated the PR. |
Make it possible to run outro transitions when manually calling $destroy on a component.
In Svelte 4, the workaround mentioned in #4056 no longer works because those APIs are not public / exported.
Fixes #4056
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint