Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent animation keyframes being deleted before animation execution end #9126

Open
wants to merge 2 commits into
base: svelte-4
Choose a base branch
from

Conversation

raythurnvoid
Copy link

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Fixes: sveltejs/kit#2044

Use the CSSAnimation object to detect when an animation is really finished and avoid the keyframes being deleted ahead of time causing the animation to abort. (The issue is noticeable only for "in" transitions that run right after page load)

Daniele Loreto added 2 commits August 21, 2023 00:15
check the animation play state with the DOM API before removing the keyframes
@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2023

⚠️ No Changeset found

Latest commit: fa4b1a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition cleanup happens too early if Kit is already running
1 participant