Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte lacks strong types in it's context functions. This PR is a draft of what this could look like. More details in this issue: #8941.
I tried to preserve backwards compatibility by replacing
key: any
withkey: {}
. It should be the same as before exceptundefined
andnull
. But I don't think someone usedundefined
ornull
as keys anyway.There are 2 commented out tests because I didn't want to think how to fix those edge cases because IDK if this PR will even be merged.
There is a nasty edge case with
getContext(Symbol())
, which returnsT | undefined
instead ofT
. But I believe if # 2 is resolved, this will be resolved too.Also, I moved
getContext
types topublic.d.ts
because JSDoc doesn't support function overloads(as far as I am aware).Is it possible for this to be merged in Svelte 5?
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint