Fix fullscreen command and improve documentation #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the error result from CMD_INVALID to CMD_FAILURE, since CMD_INVALID indicates an unknown command or parser error and neither occurs where CMD_INVALID was used.
Document the optional arguments of the fullscreen command.
RedSoxFan
approved these changes
Dec 1, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a problem that I have when using the following keybinding on an empty workspace
bindsym Mod4+v fullscreen disable,exec termite -e pulsemixer.With this binding I want to open an application but in case that another view is currently in fullscreen mode, it should leave fullscreen mode first. This does not work on an empty Workspace, because
fullscreen disablereturns with error statusCMD_INVALIDand then the following exec command will not be executed (cf. https://github.com/swaywm/sway/blob/master/sway/commands.c#L307).In i3 this binding works on empty workspaces.
The second commit documents the optional arguments of the fullscreen command, which can be found in i3's documentation too.