Allow output identifier in move, focus, and assign #3314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows output identifiers to be used with the following commands: - `move container|window to output` - `focus output` - `assign [criteria] output`
emersion
reviewed
Dec 20, 2018
| @@ -194,6 +194,9 @@ static struct cmd_results *focus_output(struct sway_seat *seat, | |||
| } | |||
| char *identifier = join_args(argv, argc); | |||
| struct sway_output *output = output_by_name(identifier); | |||
| if (!output) { | |||
| output = output_by_identifier(identifier); | |||
There was a problem hiding this comment.
Maybe we could replace output_by_{name,identifier} by a single function? Don't know if we use one without the other somewhere.
|
Superseded by #3315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows output identifiers to be used with the following commands:
move container|window|workspace to outputfocus outputassign [criteria] output