WiX: adjust manifest for static conversion #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the SPM file list after some of the modules were converted to static linking.
etcwilde
reviewed
Feb 6, 2025
| @@ -222,9 +216,6 @@ | |||
| <Component> | |||
| <File Source="$(TOOLCHAIN_ROOT)\usr\bin\PackageModel.dll" /> | |||
| </Component> | |||
| <Component> | |||
| <File Source="$(TOOLCHAIN_ROOT)\usr\bin\PackageModelSyntax.dll" /> | |||
There was a problem hiding this comment.
It looks like PackageModelSyntax is still able to go either way in https://github.com/swiftlang/swift-package-manager/pull/8268/files and https://github.com/swiftlang/swift-package-manager/blob/2215d098ed2aa991ed3f3d8c712266f14ebe4b45/Sources/PackageModelSyntax/CMakeLists.txt#L9
Does that PR need to switch it to a static archive, or are you switching things to use -DBUILD_SHARED_LIBS=NO?
There was a problem hiding this comment.
Nice catch! That should still be dynamic - I believe it ended up being that this was not profitable.
There was a problem hiding this comment.
Wait, no: swiftlang/swift-package-manager#8268
That does change PackageModelSyntax to be static, along with SwiftSDKCommand, DriverSupport.
etcwilde
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the SPM file list after some of the modules were converted to static linking.