Use swiftly_release data for the download page #873
+138
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust the download URLs and instructions to support upcoming swiftly preview release * Correct the swiftly download URLs --------- Co-authored-by: Mishal Shah <[email protected]>
Whenever swiftly publishes a new release and updates the API then the website should direct everyone to that new release in both the instructions and the download URLs.
cmcgee1024
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
…ite into swiftly-preview
|
Is there a way to split out the Swiftly stuff from the updates from |
0xTim
force-pushed
the
swiftly-preview
branch
from
77ef164 to
1cda4bf
Compare
0xTim
approved these changes
Jan 21, 2025
|
@cmcgee1024 want to fix the merge conflicts? Then we can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the download pages for Linux and macOS so that they use the swiftly_release information to get the latest swiftly version to set the URL's and instructions.
Motivation:
We would like to use the API to automatically populate the swiftly information when a new release is made instead of having to update the Linux and macOS pages each time.
Modifications:
Pulled in the latest commits from main with the swiftly release API.
Result:
The change will automatically set the URLs and instructions relating to the swiftly version.