Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote exit tests to API #324

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 2, 2024

This PR promotes exit tests to API, pending approval of the proposal at swiftlang/swift-evolution#2718.

View the full proposal here.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added tools integration Integration of swift-testing into tools/IDEs windows 🪟 Windows support linux 🐧 Linux support (all distros) darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support public-api Affects public API swift-6 labels Apr 2, 2024
@grynspan grynspan self-assigned this Apr 2, 2024
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from fe21f14 to 988ddfe Compare April 2, 2024 17:57
@grynspan grynspan added the enhancement New feature or request label Apr 2, 2024
@grynspan grynspan marked this pull request as draft April 2, 2024 22:10
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from 988ddfe to 697123a Compare April 10, 2024 17:40
@grynspan grynspan changed the title [SWT-0001] Exit tests [SWT-NNNN] Exit tests Apr 10, 2024
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch 3 times, most recently from 19f37c3 to 4825821 Compare April 12, 2024 13:30
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch 2 times, most recently from feb425b to e84b014 Compare April 30, 2024 14:23
@grynspan grynspan added the api-proposal API proposal PRs (documentation only) label May 1, 2024
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch 2 times, most recently from 6f0e7f0 to 875b870 Compare May 16, 2024 14:41
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from 875b870 to 4365611 Compare May 24, 2024 20:47
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from 4365611 to 7d25e07 Compare July 12, 2024 15:43
@grynspan
Copy link
Contributor Author

Rebased.

@grynspan grynspan removed the swift-6 label Jul 25, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan requested a review from stmontgomery October 23, 2024 18:28
@ikesyo ikesyo marked this pull request as ready for review November 15, 2024 15:12
@ikesyo ikesyo marked this pull request as draft November 15, 2024 15:13
@grynspan grynspan modified the milestones: Swift 6.1, Swift 6.2 Nov 19, 2024
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from 0d48878 to 39551cf Compare December 5, 2024 22:44
@maartene
Copy link

maartene commented Jan 6, 2025

Is there any news on this PR?

@grynspan
Copy link
Contributor Author

grynspan commented Jan 6, 2025

I'm still actively maintaining this branch/PR. We are not planning to formally propose this feature until the testing workgroup is set up, at the earliest.

@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch 4 times, most recently from d9d9f53 to fc1d61c Compare February 24, 2025 21:38
@grynspan grynspan added freebsd 😈 FreeBSD support openbsd 🐡 OpenBSD support labels Feb 24, 2025
@grynspan grynspan marked this pull request as ready for review February 24, 2025 21:48
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from 31e4492 to 417cb17 Compare February 28, 2025 21:01
@grynspan
Copy link
Contributor Author

@swift-ci test

grynspan added 2 commits March 3, 2025 16:14
One of the first enhancement requests we received for swift-testing was the
ability to test for precondition failures and other critical failures that
terminate the current process when they occur. This feature is also frequently
requested for XCTest. With swift-testing, we have the opportunity to build such
a feature in an ergonomic way.

Read the full proposal [here](https://github.com/apple/swift-testing/blob/jgrynspan/exit-tests-proposal/Documentation/Proposals/NNNN-exit-tests.md).
@grynspan grynspan changed the title [SWT-NNNN] Exit tests Promote exit tests to API Mar 3, 2025
@grynspan grynspan removed the api-proposal API proposal PRs (documentation only) label Mar 3, 2025
@grynspan grynspan force-pushed the jgrynspan/exit-tests-proposal branch from 417cb17 to 5705163 Compare March 3, 2025 21:32
@grynspan
Copy link
Contributor Author

grynspan commented Mar 3, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Mar 3, 2025

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support enhancement New feature or request exit-tests ☠️ Work related to exit tests freebsd 😈 FreeBSD support linux 🐧 Linux support (all distros) openbsd 🐡 OpenBSD support public-api Affects public API tools integration Integration of swift-testing into tools/IDEs windows 🪟 Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants