utils: remove swiftinterfaces from the build image #79840
Conversation
|
Please test with following PRs: @swift-ci please smoke test |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
CC: @xymus |
These cannot be re-serialized due to a bug in the serialization logic where we do not inject the VFS overlay for the system modules. Bug: swiftlang#79839
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please smoke test |
1 similar comment
|
Please test with following PRs: @swift-ci please smoke test |
There was a problem hiding this comment.
I tested this in #79185 and this specific aspect is working in CI with the tiny fix below.
|
@swift-ci please smoke test macOS platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
CC: @xymus |
|
It looks like this will correctly work around the change from #79588. Relying only on binary swiftmodules for a local build should be fine, but I would caution against it for distributed SDKs and toolchains. For more context, we're very slowly moving towards using more and more textual swiftinterfaces for distributed modules. Binary swiftmodules are not designed to support changes in dependencies. Notably, a change to imported headers can force the compiler to drop entire decls, that's in the degraded mode as it crashes otherwise. So when building the modules on one machine and deploying on a different one the binary swiftmodules may be unusable, whereas swiftinterfaces are designed to be rebuilt on each machine against the local dependencies. |
|
@xymus hmm, the problem is that the re-serialization will fail with module not found errors for underlying clang modules. I suspect that this is due to VFS overlays not being applied when re-serialising the modules. |
These cannot be reserialized due to a bug in the serialization logic where we do not inject the VFS Ovelay for the system modules.
Bug: #79839