Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in y/n prompts #141 fix #222

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

johnbute
Copy link
Contributor

@johnbute johnbute commented Feb 7, 2025

Changed certain prompts for consistency reasons
Motivation:

Certain prompts would only accept 'y' instead of 'Y', while others accepted both these options. This fix ensures consistency when prompting users
Modifications:

Simply changed certain prompts and utilizing the promptForConfirmation method
Result:

More consistent user experience when answering prompts

…in prompts to user only accepting 'y', or 'n', utilized the promptForConfirmation method to ensure consistency in user experience.
@cmcgee1024
Copy link
Member

@johnbute there's an actionable error in the failed format check build:

Please run 'swift run swiftformat .' to format the source code.

Run that, commit the changes and push to fix the test.

@cmcgee1024
Copy link
Member

@swift-ci test macOS

@cmcgee1024 cmcgee1024 merged commit 7517530 into swiftlang:main Feb 11, 2025
19 checks passed
@cmcgee1024
Copy link
Member

This looks good. Thank you @johnbute for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants