Foreground process fix #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2025 12:24
…ould fail if the user gave 'Y' instead of 'y' to continue, now all prompting is consistent
|
Fixes #223 |
|
@johnbute this is a really good fix to have. Thanks for tracking this down. Can you reformat the code, commit and push it? |
cmcgee1024
reviewed
Feb 13, 2025
cmcgee1024
reviewed
Feb 13, 2025
added 2 commits
February 13, 2025 12:04
…fork-swiftly into foreground-process-fix
|
@swift-ci test macOS |
|
Thank you for your contribution @johnbute . This will be a really good fix to have in swiftly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where a child process did not set main process back into foreground, causing issues such as not being able to let the user prompt y/n
Motivation:
When a child process is created and set into the foreground then terminates, the main process doesn't have the ability to prompt the user anymore.
Modifications:
Simply add a few lines to transfer the main process back to the foreground once the child process finishes
Result:
Allows for user interaction (user input), better resource management, and signal handling.