Add support for Debian 12 in the install script #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the relatively mechanical changes needed to add support for Debian 12 in the install script. Debian Docker nightlies are not yet available, so we use Ubuntu's Dockerfile for computing the dependency list for now. This has been tested on a Debian 12 installation and is able to correctly install swiftly.
|
@swift-ci test |
|
Here's the list of Debian 12 dependencies that were collected when adding that platform to the upcoming release: swiftly/Sources/LinuxPlatform/Linux.swift Line 206 in 315bd00 |
|
@cmcgee1024 Are you suggesting hardcoding the list for Debian for now, instead of falling back to the Ubuntu Dockerfile? |
|
@jakepetroules it would be consistent with the approach that we're taking with the latest in main/release 1.0. It will be good to have some kind of a API to get that information better than parsing Dockerfiles. |
|
@jakepetroules if you want to have Debian 12 support you could build your own swiftly from the main/release 1.0 branches and use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the relatively mechanical changes needed to add support for Debian 12 in the install script. Debian Docker nightlies are not yet available, so we use Ubuntu's Dockerfile for computing the dependency list for now.
This has been tested on a Debian 12 installation and is able to correctly install swiftly.