[Map] markers, polygons and polylines removal

[sblondeau]

Q	A
Bug fix?	no
New feature?	yes
Issues	Fix #...
License	MIT

Add new methods to remove markers, polygons or polylines (map elements)
Map elements will be store in SplObjectStorage instead of arrays.

When create a map element, you can now add an optional identfier (string).
New methods getMarker(string identifier), getPolygon(string identifier) and getPolyline(string $identifier) car retreive a map element from its identfiier.

example
$departureMarker = new Marker (
position: new Point(45.7640, 4.8357),
title: 'Lyon',
identifier: 'departure'
)

$map->addMarker($departureMarker);

// remove marker with
$map->removeMarker($departureMarker)
// or 
$map->removeMarker($map->getMarker('departure'));

[Kocal]

Hi @sblondeau and thanks for your suggestion, I was waiting for someone to open it! :D

It's a very, very good start, but there are still things to refactor and simplify:

1. I believe Map::remove*() methods must accept Marker|string $markerOrId as parameter, so we can remove methods Map::get*()
2. Map::get*() methods do not really make sense to me, since there is no modifiers on Marker/Polygon/Polyline. Once you construct them, you can't alter them, so not point for Map::get*().
3. Some architecture things can be improved, see review comments
4. Types definitions in assets/ must be updated to, since you added a new property identifier (which can be shortened and changed to id)
5. Also, please apply Fapbot's suggestions

Thanks, and do not hesitate if necessary! :)

[smnandre]

Do you need some help here @sblondeau ?

[sblondeau]

Do you need some help here @sblondeau ?

No time at all last week, but I will try to work on it in the next day :-) Thanks for your comments

[sblondeau]

2. `Map::get*()` methods do not really make sense to me, since there is no modifiers on `Marker`/`Polygon`/`Polyline`. Once you construct them, you can't alter them, so not point for `Map::get*()`.

Thanks for your comments @Kocal. One question, that's true that a Marker is readonly... but can we imagine that we getMarker() to modify its position, title or infoWindow ? so we should remove and recreate it ?

[Kocal]

2. `Map::get*()` methods do not really make sense to me, since there is no modifiers on `Marker`/`Polygon`/`Polyline`. Once you construct them, you can't alter them, so not point for `Map::get*()`.

Thanks for your comments @Kocal. One question, that's true that a Marker is readonly... but can we imagine that we getMarker() to modify its position, title or infoWindow ? so we should remove and recreate it ?

For the moment, yes, we can implement Marker, Polygon and Polyline removal without the need of Map::get*().

If really necessary, let's open a separate PR to make them non-readonly and implement Map::get*().

[Kocal]

Thanks for applying suggestions.

Can you please revert changes unrelated to Map and the removal feature please? 🙏🏻

[Kocal]

I really like where we are now!

I'll test your PR locally before approving it and merging it.

[Kocal]

I've tested your PR and it works well:

Enregistrement.de.l.ecran.2025-02-15.a.17.14.57.mov

I did some minor adjustments to mark those classes as internal.

[Kocal]

Thanks @sblondeau.