Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and tests to change twig:ux:component to twig:UX:Component #2555

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Feb 8, 2025

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Applying suggestions for Symfony UX Components section in OP's message, see #2118

@Kocal Kocal added the docs Improvements or additions to documentation label Feb 8, 2025
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 8, 2025
@smnandre
Copy link
Member

smnandre commented Feb 9, 2025

Well.... this wasnt my suggestion ^^

And we made this choice because it felt weird to use <twig:UX:Icon (lower / UPPER / Camel).

Open to change of course, but does not feel the previous topic raised massive interest :)

A2: Symfony UX components should use lowercase casing style in documentation, code blocks, and social media.

😅

@smnandre
Copy link
Member

smnandre commented Feb 9, 2025

And this would require a lot of other changes since we acted the ux:icon case (commands, docs, website, ...).

Not strongly opiniated here (really) and open to change, but then i guess we should do it all at once, to not confuse dev/users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants