Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix links to changed dist files #2563

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Feb 11, 2025

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

I noticed that URLs to changed dist files are invalid, they refer to the current repository symfony/ux instead of the repository where the PR has been created:
image

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 11, 2025
@Kocal Kocal force-pushed the fix-ci-dist-files-urls branch 2 times, most recently from 6cd77a5 to c039387 Compare February 11, 2025 07:30
@Kocal Kocal force-pushed the fix-ci-dist-files-urls branch from de23a85 to db40320 Compare February 11, 2025 07:37
@symfony symfony deleted a comment from github-actions bot Feb 11, 2025
@Kocal
Copy link
Member Author

Kocal commented Feb 11, 2025

I'm merging, since manipulating CI workflows for pull_request requires changes to be merged to be effective.

@Kocal Kocal added the DX label Feb 11, 2025
@Kocal Kocal merged commit 24c4fd3 into symfony:2.x Feb 11, 2025
58 of 59 checks passed
Kocal added a commit that referenced this pull request Feb 11, 2025
This PR was merged into the 2.x branch.

Discussion
----------

[CI] Fix dist files base/head informations

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

Follows #2563

Commits
-------

5fec9c2 [CI] Fix dist files base/head informations
@Kocal Kocal deleted the fix-ci-dist-files-urls branch February 11, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants