Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudlogs): cloudtrail SNS ingestion support #141

Merged
merged 8 commits into from
Feb 11, 2025
Merged

feat(cloudlogs): cloudtrail SNS ingestion support #141

merged 8 commits into from
Feb 11, 2025

Conversation

lorenzo-merici
Copy link
Collaborator

@lorenzo-merici lorenzo-merici commented Jan 25, 2025 •
edited
Loading

Updated the CloudFormation s3 module to enhance support for CloudTrail notifications. Key changes include:

  • Added optional creation of an SNS Topic and Subscription for CloudTrail notifications.
  • Introduced new parameters (CreateTopic, TopicARN, Endpoint) to control SNS topic creation and configuration.
  • Improved descriptions for parameters and outputs for clarity.
  • Added conditions and policies to support dynamic SNS topic creation.

@lorenzo-merici lorenzo-merici marked this pull request as ready for review February 7, 2025 17:10
@lorenzo-merici lorenzo-merici requested review from a team as code owners February 7, 2025 17:11
ravinadhruve10
ravinadhruve10 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have we tested this out?

@lorenzo-merici lorenzo-merici merged commit 5372b1b into main Feb 11, 2025
3 checks passed
@lorenzo-merici lorenzo-merici deleted the feat-cloudtrail-sns-ingestion-support branch February 11, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acaprari acaprari acaprari approved these changes

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzo-merici @acaprari @ravinadhruve10