Response content length #129
Merged
+44
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-krieger
force-pushed
the
response-content-length
branch
from
dfbc2ed
to
59f83f0
Compare
This was referenced Oct 31, 2024
ben-krieger
force-pushed
the
response-content-length
branch
from
59f83f0
to
bdd54f0
Compare
syumai
reviewed
Nov 7, 2024
| Uint8ArrayClass = js.Global().Get("Uint8Array") | ||
| ErrorClass = js.Global().Get("Error") | ||
| ReadableStreamClass = js.Global().Get("ReadableStream") | ||
| FixedLengthStreamClass = js.Global().Get("FixedLengthStream") |
There was a problem hiding this comment.
FixedLengthStream is an original feature of Cloudflare.
So once we start supporting another runtime (such as Deno), we need to check its existence.
However, since syumai/workers currently only supports Cloudflare Workers, it's OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When HTTP response from Go contains
Content-Lengthheader, then the Cloudflare response will also containContent-Lengthand not useTransfer-Encoding: chunked.Motivation
Transfer encoding ideally shouldn't change from the Go server. In my case, my client can't handle chunked responses.