Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing title variable #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skyiron
Copy link

@skyiron skyiron commented Sep 11, 2018

In the original version of jssocial, I found that the title variable was missing from shareurls that were supposed to have it. I checked the code, but couldn't find the title variable defined anywhere, so I've added it.

This is my first pull request ever (I'm nervous!) I have read the contributing notes.
I've not done the grunt tests, but I've run github/jssocials/test/jssocials.html
Everything passed except for share rendering: set custom handlers with 'on', but I think it is to be expected in this case. Here are the results of that test.

Expected:  
{
  "share": "testshare",
  "shareUrl": "http://test.com/share/",
  "text": "testtext",
  "url": "testurl"
}

Result: 	
{
  "share": "testshare",
  "shareUrl": "http://test.com/share/",
  "text": "testtext",
  "title": "jsSocials Test Suite",
  "url": "testurl"
}

Diff: 	
 {
   "share":  "testshare",
   "shareUrl":  "http://test.com/share/",
   "text":  "testtext",
   "title": "jsSocials Test Suite",
   "url":  "testurl"
 } 

I've tested a different branch (that contained the above changes) on my server and the title variable was correctly added to the url.

If I've gone about this pull request incorrectly, made any mistakes or you have any feedback, I'd love to hear it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant