Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original version of jssocial, I found that the title variable was missing from shareurls that were supposed to have it. I checked the code, but couldn't find the title variable defined anywhere, so I've added it.
This is my first pull request ever (I'm nervous!) I have read the contributing notes.
I've not done the grunt tests, but I've run github/jssocials/test/jssocials.html
Everything passed except for share rendering: set custom handlers with 'on', but I think it is to be expected in this case. Here are the results of that test.
I've tested a different branch (that contained the above changes) on my server and the title variable was correctly added to the url.
If I've gone about this pull request incorrectly, made any mistakes or you have any feedback, I'd love to hear it. Thanks!