Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the COMMENTS.OLDER_FIRST and RECENT_FIRST to make it clear it is an action #234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mig5
Copy link

@mig5 mig5 commented Jan 30, 2025

We have seen multiple users express confusion that, in the Comments section of an item, 'Older first' and 'Recent first' seem reversed to most people's instinctive understanding.

When they see 'Older first', they think 'the comments are being shown as Oldest first', when in fact the reverse is true.

The reason is that the button text is really representing a proposed 'action', not representative of its current state. Much like how a form button 'Submit' or 'Save' does not mean 'It is submitted' or 'It is saved', but that clicking the button will make it so.

I think the cause for the confusion is that the 'Older first' / 'Recent first' do not look like normal buttons - they look like sort-order toggles.

In this PR I have changed it to have the 'Click to view' prefix, which makes it clearer to English speakers that taking an action (clicking on it) will result in that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant