Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a warning about caching and updates #117

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

creachadair
Copy link
Member

Updates tailscale/corp#22445

@creachadair creachadair force-pushed the mjf/poll-to-doc branch 2 times, most recently from b1104ae to 1d7a558 Compare August 20, 2024 16:03
@creachadair creachadair marked this pull request as ready for review August 20, 2024 16:04
docs/README.md Outdated
> the next update.
>
> As a general rule, we recommend you _not_ enable a cache unless the program
> cannot tolerate any delay at startup. Otherwise, if you must use a cache, we
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: I'd say something a bit stronger than "delay at startup" here, it's specifically being able to tolerate an outage of the secrets service, or being in the bootstrap path for same. The choice is less between "startup is fast" or "startup is slow", it's "does the thing start at all when the vault or tailscale are down"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let me see what I can do. I'm specifically calling this out because I keep seeing caches get enabled for things where they probably shouldn't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And yeah, this was... I think awly's worry with having a cache, that it ends up being enabled for the wrong reasons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, and you and I discussed that at the time. I think the tradeoff was probably worth it, because it's better to enable it for the wrong reasons than to have someone continue to use ad-hoc secrets management because of that concern.

@creachadair
Copy link
Member Author

(merging around the CI error, which is unrelated and fixed in #116)

@creachadair creachadair merged commit 79772de into main Aug 20, 2024
1 check failed
@creachadair creachadair deleted the mjf/poll-to-doc branch August 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants