Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide completions from CSS language server inside @import "…" source(…) #1091

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Nov 15, 2024

This hides completions from the CSS language server when inside @import source(…), @import theme(…), and @import prefix(…)

Because of the way we fake stuff to the underlying service it thinks these are valid places to provide standard CSS completions but they're not.

before:

Screenshot 2025-03-28 at 21 32 08

after:
Screenshot 2025-03-28 at 21 34 38

@thecrypticace thecrypticace force-pushed the fix/dont-complete-in-import-position branch from f35f4ac to e0f147a Compare March 29, 2025 01:21
@thecrypticace thecrypticace force-pushed the fix/dont-complete-in-import-position branch from e0f147a to 439e07c Compare March 29, 2025 01:25
@thecrypticace thecrypticace marked this pull request as ready for review March 29, 2025 01:30
@thecrypticace thecrypticace merged commit 6b306ba into main Apr 1, 2025
12 checks passed
@thecrypticace thecrypticace deleted the fix/dont-complete-in-import-position branch April 1, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants