Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce deprecated theme values #14932

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

adamwathan
Copy link
Member

This PR reintroduces the blur, shadow, drop-shadow, and rounded utilities that were removed in #14849, just to preserve backward compatibility as much as possible.

These values are still considered deprecated, and we register them as inline reference with the theme to ensure they don't produce any CSS variables in output:

/* Deprecated */
@theme default inline reference {
  --blur: 8px;
  --shadow: 0 1px 3px 0 rgb(0 0 0 / 0.1), 0 1px 2px -1px rgb(0 0 0 / 0.1);
  --drop-shadow: 0 1px 2px rgb(0 0 0 / 0.1), 0 1px 1px rgb(0 0 0 / 0.06);
  --radius: 0.25rem;
}

These values won't be included in the documentation, and in the future we'll add an option to explicitly register things as deprecated so that they don't appear as completions in IntelliSense either.

@adamwathan adamwathan requested a review from a team as a code owner November 9, 2024 14:13
@adamwathan adamwathan merged commit 1dbd99d into next Nov 9, 2024
1 check passed
@adamwathan adamwathan deleted the change/reintroduce-deprecated-theme-values branch November 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant