IOS-7807 SUI #849
Merged
IOS-7807 SUI #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siblockchaina
requested review from
tureck1y,
dbaturin and
a team
as code owners
tureck1y
reviewed
Sep 20, 2024
BlockchainSdk/Common/Factories/EstimationFeeAddressFactory.swift
Outdated
Show resolved
Hide resolved
tureck1y
previously approved these changes
Sep 24, 2024
dbaturin
previously approved these changes
Sep 24, 2024
Balashov152
reviewed
Sep 25, 2024
| @@ -97,6 +97,8 @@ struct EstimationFeeAddressFactory { | |||
| return "EQAY92urFDKejoDRdi_EfRKLGB1JkGjD8z1inj_DhgBaD0Xo" | |||
| case .koinos: | |||
| return "1C423Vbd44zjghhJR5fKJdLFS3rgVFUc9A" | |||
| case .sui: | |||
| return "" | |||
There was a problem hiding this comment.
сюда бы задачку что бы не забыть )
Andoran90
requested changes
Sep 26, 2024
|
Вообще по код стайлу хорошо бы форматер нам как то заюзать, или хотя бы прогонять его раз в месяц |
|
мы же будем переносить бсдк в репу приложения, форматер тогда сможем юзать |
1 task
siblockchaina
dismissed stale reviews from dbaturin and tureck1y
via
e61f7ce
siblockchaina
requested review from
Balashov152,
Andoran90,
tureck1y and
dbaturin
Balashov152
previously approved these changes
Sep 27, 2024
Andoran90
previously approved these changes
Sep 30, 2024
siblockchaina
dismissed stale reviews from Andoran90 and Balashov152
via
f1b94a9
tureck1y
approved these changes
Oct 1, 2024
Andoran90
approved these changes
Oct 2, 2024
Balashov152
approved these changes
Oct 2, 2024
dbaturin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prev PR #844