Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start: add creation of binary port #715

Merged
merged 2 commits into from
Mar 7, 2024
Merged

start: add creation of binary port #715

merged 2 commits into from
Mar 7, 2024

Conversation

better0fdead
Copy link
Contributor

Added default binary port for tarantool 3.0 .
Added binary port creation for tarantool < 3.0.
Added ability to connect to instance using binary port.

Closes #574

@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 7 times, most recently from 778cd96 to 9e15623 Compare December 20, 2023 04:09
@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 4 times, most recently from d4987b7 to a0fc6d0 Compare December 27, 2023 01:29
@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 6 times, most recently from f32103b to e86c1e5 Compare January 23, 2024 22:50
@better0fdead better0fdead added the full-ci Enables full ci tests label Jan 26, 2024
@better0fdead better0fdead marked this pull request as ready for review February 14, 2024 08:48
psergee
psergee reviewed Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch.

cli/running/cluster_instance.go Outdated Show resolved Hide resolved
cli/running/cluster_instance.go Outdated Show resolved Hide resolved
cli/running/internal/layout/multi_inst_layout.go Show resolved Hide resolved
cli/running/internal/layout/tntctl_layout.go Show resolved Hide resolved
cli/running/running.go Outdated Show resolved Hide resolved
test/integration/connect/test_connect.py Outdated Show resolved Hide resolved
test/integration/connect/test_connect.py Outdated Show resolved Hide resolved
test/integration/connect/test_connect.py Outdated Show resolved Hide resolved
test/integration/replicaset/test_replicaset.py Outdated Show resolved Hide resolved
test/integration/running/test_running.py Outdated Show resolved Hide resolved
@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 2 times, most recently from e359264 to 8c27064 Compare February 21, 2024 03:34
psergee
psergee reviewed Feb 21, 2024
View reviewed changes
cli/running/running.go Outdated Show resolved Hide resolved
cli/running/script_instance.go Outdated Show resolved Hide resolved
test/integration/connect/test_connect.py Outdated Show resolved Hide resolved
test/integration/connect/test_connect.py Show resolved Hide resolved
@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 2 times, most recently from e052db7 to e0ad025 Compare February 22, 2024 09:21
psergee
psergee reviewed Feb 22, 2024
View reviewed changes
test/integration/connect/test_connect.py Outdated Show resolved Hide resolved
test/integration/connect/test_connect.py Outdated Show resolved Hide resolved
@better0fdead better0fdead removed the full-ci Enables full ci tests label Mar 4, 2024
@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 3 times, most recently from cface88 to 7760a9a Compare March 5, 2024 11:18
@better0fdead
start: add creation of binary port
b6ff2fd 
Added default binary port for tarantool 3.0 .
Added binary port creation for tarantool < 3.0.

Closes #574
@better0fdead better0fdead force-pushed the better0fdead/bin-port branch 2 times, most recently from 15a2d55 to 19bcd2a Compare March 6, 2024 21:22
@better0fdead
connect: add binary port connection to instance
7297b6b 
Added ability to connect to instance using binary port.

Follow up #574
psergee
psergee approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@psergee psergee added the full-ci Enables full ci tests label Mar 7, 2024
@psergee psergee merged commit 5a4544e into master Mar 7, 2024
44 checks passed
@psergee psergee deleted the better0fdead/bin-port branch March 7, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psergee psergee psergee approved these changes

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a binary port on instance start
2 participants
@better0fdead @psergee